clangparser: mark incomplete arrays as incomplete without failing #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 20, 2023
tyroguru
approved these changes
Dec 20, 2023
Attempting to complete a type which can't be completed currently fails oilgen. For incomplete arrays, which we know are not possible to complete, return false deliberately. `requireCompleteType` likely needs to not fail in all cases in the future. For now this works. Test plan: - `std::unique_ptr<long[]>` used to fail the generation. Now it can successfully codegen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clangparser: mark incomplete arrays as incomplete without failing
Attempting to complete a type which can't be completed currently fails oilgen.
For incomplete arrays, which we know are not possible to complete, return false
deliberately.
requireCompleteTypelikely needs to not fail in all cases in the future. Fornow this works.
Test plan:
std::unique_ptr<long[]>used to fail the generation. Now it cansuccessfully codegen.