Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataPartition] Use per-op IR builder during slicing #53

Open
wants to merge 1 commit into
base: ws-main
Choose a base branch
from

Conversation

htyu
Copy link
Contributor

@htyu htyu commented Feb 19, 2025

Ops in a slice can have different async task ids such as

    %cst = arith.constant {async_task_id = dense<[0, 1, 2]> : vector<3xi32>} dense<0.000000e+00> : tensor<128x256xf32, #blocked> loc(#loc1)

        %31 = ttng.tmem_alloc %arg8 {async_task_id = dense<[1, 2]> : vector<2xi32>} : (tensor<128x256xf32, #blocked>) -> !ttg.memdesc<128x256xf32, #tmem, #ttng.tensor_memory, mutable> loc(#loc27)

Use a separate IR builder per op to avoid the mixing of task ids.

@htyu htyu requested review from bertmaher and manman-ren February 19, 2025 16:51
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants