Skip to content

Commit

Permalink
Delete cfgs argument of buildscript_genrule
Browse files Browse the repository at this point in the history
Summary: This is never set to anything but an empty list, and never serialized.

Reviewed By: zertosh, diliop

Differential Revision: D59229233

fbshipit-source-id: 2adf2e25f82d905a6e031e515b7682ad8a4507f3
  • Loading branch information
David Tolnay authored and facebook-github-bot committed Jul 1, 2024
1 parent 74d7d84 commit 9e53dab
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
5 changes: 0 additions & 5 deletions src/buck.rs
Original file line number Diff line number Diff line change
Expand Up @@ -796,7 +796,6 @@ pub struct BuildscriptGenrule {
pub package_name: String,
pub version: Version,
pub features: Selectable<UniverseName, BTreeSet<String>>,
pub cfgs: Vec<String>,
pub env: BTreeMap<String, String>,
pub path_env: BTreeMap<String, String>,
pub args_env: BTreeMap<String, String>,
Expand All @@ -810,7 +809,6 @@ impl Serialize for BuildscriptGenrule {
package_name,
version,
features,
cfgs,
env,
path_env,
args_env,
Expand All @@ -822,9 +820,6 @@ impl Serialize for BuildscriptGenrule {
map.serialize_entry("args_env", args_env)?;
}
map.serialize_entry("buildscript_rule", &NameAsLabel(buildscript_rule))?;
if !cfgs.is_empty() {
map.serialize_entry("cfgs", cfgs)?;
}
if !env.is_empty() {
map.serialize_entry("env", env)?;
}
Expand Down
1 change: 0 additions & 1 deletion src/fixups.rs
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,6 @@ impl<'meta> Fixups<'meta> {
package_name: self.package.name.clone(),
version: self.package.version.clone(),
features: buck::Selectable::Value(features.clone()),
cfgs: Vec::new(),
env: BTreeMap::new(),
path_env: BTreeMap::new(),
args_env: BTreeMap::new(),
Expand Down

0 comments on commit 9e53dab

Please sign in to comment.