: don't panic in relative_path #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52989646 |
Summary: adds a github actions smoke test for the 'buckify' command. updated to make use of the example project for this. Test Plan: Imported from GitHub, without a `Test Plan:` line. https://github.com/facebookincubator/reindeer/actions/runs/7620862356/job/20756295189 Differential Revision: D52968685 Pulled By: shayne-fletcher
shayne-fletcher
added a commit
to shayne-fletcher/reindeer
that referenced
this pull request
Jan 23, 2024
Summary: if in `relative_path` we find `to` and `from` are in different file systems, don't panic but instead just return `to` unmodified. testing indicates that `reindeer buckify` continues to work as normal with that choice in this case (and so we can avoid needing `CARGO_HOME` workarounds). Differential Revision: D52989646
shayne-fletcher
force-pushed
the
export-D52989646
branch
from
8521384 to
c730f1a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52989646 |
shayne-fletcher
added a commit
to shayne-fletcher/reindeer
that referenced
this pull request
Jan 23, 2024
Summary: if in `relative_path` we find `to` and `from` are in different file systems, don't panic but instead just return `to` unmodified. testing indicates that `reindeer buckify` continues to work as normal with that choice in this case (and so we can avoid needing `CARGO_HOME` workarounds). Differential Revision: D52989646
shayne-fletcher
force-pushed
the
export-D52989646
branch
from
c730f1a to
d1daf8d
Compare
shayne-fletcher
added a commit
to shayne-fletcher/reindeer
that referenced
this pull request
Jan 23, 2024
Summary: if in `relative_path` we find `to` and `from` are in different file systems, don't panic but instead just return `to` unmodified. testing indicates that `reindeer buckify` continues to work as normal with that choice in this case (and so we can avoid needing `CARGO_HOME` workarounds). Differential Revision: D52989646
shayne-fletcher
force-pushed
the
export-D52989646
branch
from
d1daf8d to
a2cfa6a
Compare
Summary: if in `relative_path` we find `to` and `from` are in different file systems, don't panic but instead just return `to` unmodified. testing indicates that `reindeer buckify` continues to work as normal with that choice in this case (and so we can avoid needing `CARGO_HOME` workarounds). Differential Revision: D52989646
shayne-fletcher
force-pushed
the
export-D52989646
branch
from
a2cfa6a to
6f8c3d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: if in
relative_pathwe findtoandfromare in different file systems, don't panic but instead just returntounmodified. testing indicates thatreindeer buckifycontinues to work as normal with that choice in this case.Differential Revision:
D52989646
Privacy Context Container: L1122763