Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove unused headers and gflags #12248

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

majetideepak
Copy link
Collaborator

@majetideepak majetideepak commented Feb 3, 2025

Remove unused headers in velox/common/base/VeloxException.h

This is required for the dynamic library PR to remove dependency on GLOG
#11439 (comment)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 3, 2025
Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 6489e7f
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/67a269dff0f36300081c116b

@mohsaka
Copy link
Contributor

mohsaka commented Feb 4, 2025

@majetideepak

Seems like a reliance on glog on velox/common/base/Exceptions.h which resolved its dependency through velox/common/base/VeloxException.h is causing some failures.

@majetideepak
Copy link
Collaborator Author

@mohsaka There are a couple of such issues. I am fixing them locally.

@majetideepak majetideepak force-pushed the remove-headers-2 branch 2 times, most recently from 0b7185b to f6449a8 Compare February 4, 2025 18:15
@majetideepak
Copy link
Collaborator Author

@kgpai this is ready for review. Can you please take a look? Thanks.

@mohsaka
Copy link
Contributor

mohsaka commented Feb 5, 2025

@majetideepak Attempted to build the code with the dynamic library PR but the dependency was moved to Exceptions.h.

The include tree seems to be
Udf.h -> Macros.h -> Type.h -> Exceptions.h
-> SimpleFunctionApi.h -> CppToType.h -> Type.h -> Exceptions.h
-> Registerer.h -> SimpleFunctionMetadata.h -> Exceptions.h
-> Registerer.h -> SimpleFunctionMetadata.h -> ***** -> Exceptions.h
-> Registerer.h -> SimpleFunctionAdapter -> Vector stuff -> Exceptions.h

Macros.h needed for VELOX_DEFINE_FUNCTION_TYPES
Registerer.h needed for registerFunction

@majetideepak
Copy link
Collaborator Author

@mohsaka thanks for the update! This cleanup is required anyway.

the dependency was moved to Exceptions.h.

I will take a look at this further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants