-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Remove unused headers and gflags #12248
base: main
Are you sure you want to change the base?
refactor: Remove unused headers and gflags #12248
Conversation
✅ Deploy Preview for meta-velox canceled.
|
Seems like a reliance on glog on |
@mohsaka There are a couple of such issues. I am fixing them locally. |
0b7185b
to
f6449a8
Compare
@kgpai this is ready for review. Can you please take a look? Thanks. |
@majetideepak Attempted to build the code with the dynamic library PR but the dependency was moved to Exceptions.h. The include tree seems to be Macros.h needed for |
@mohsaka thanks for the update! This cleanup is required anyway.
I will take a look at this further. |
Remove unused headers in
velox/common/base/VeloxException.h
This is required for the dynamic library PR to remove dependency on GLOG
#11439 (comment)