feat(aggregate): Add complex type to map_union_sum #12268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69204449 |
✅ Deploy Preview for meta-velox canceled.
|
peterenescu
added a commit
to peterenescu/velox
that referenced
this pull request
Feb 11, 2025
…#12268) Summary: Adds complex type to Presto function map_union_sum. Addition required some additional surgery in order to make primitives/strings accumulator forward compatible with ComplexType accumulator, namely functions extract/addValues. Differential Revision: D69204449
peterenescu
force-pushed
the
export-D69204449
branch
from
1ec4d67 to
09d2b5a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69204449 |
peterenescu
added a commit
to peterenescu/velox
that referenced
this pull request
Feb 11, 2025
…#12268) Summary: Adds complex type to Presto function map_union_sum. Addition required some additional surgery in order to make primitives/strings accumulator forward compatible with ComplexType accumulator, namely functions extract/addValues. Differential Revision: D69204449
peterenescu
force-pushed
the
export-D69204449
branch
from
09d2b5a to
59dac08
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69204449 |
peterenescu
added a commit
to peterenescu/velox
that referenced
this pull request
Feb 11, 2025
…#12268) Summary: Adds complex type to Presto function map_union_sum. Addition required some additional surgery in order to make primitives/strings accumulator forward compatible with ComplexType accumulator, namely functions extract/addValues. Differential Revision: D69204449
peterenescu
force-pushed
the
export-D69204449
branch
from
59dac08 to
a5f9f77
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69204449 |
peterenescu
added a commit
to peterenescu/velox
that referenced
this pull request
Feb 11, 2025
…#12268) Summary: Adds complex type to Presto function map_union_sum. Addition required some additional surgery in order to make primitives/strings accumulator forward compatible with ComplexType accumulator, namely functions extract/addValues. Differential Revision: D69204449
peterenescu
force-pushed
the
export-D69204449
branch
from
a5f9f77 to
cfb526c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69204449 |
peterenescu
added a commit
to peterenescu/velox
that referenced
this pull request
Feb 12, 2025
…#12268) Summary: Adds complex type to Presto function map_union_sum. Addition required some additional surgery in order to make primitives/strings accumulator forward compatible with ComplexType accumulator, namely functions extract/addValues. Differential Revision: D69204449
peterenescu
force-pushed
the
export-D69204449
branch
from
cfb526c to
daa25a8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69204449 |
…#12268) Summary: Adds complex type to Presto function map_union_sum. Addition required some additional surgery in order to make primitives/strings accumulator forward compatible with ComplexType accumulator, namely functions extract/addValues. Differential Revision: D69204449
peterenescu
force-pushed
the
export-D69204449
branch
from
daa25a8 to
dc60f50
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69204449 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Adds complex type to Presto function map_union_sum. Addition required some additional surgery in order to make primitives/strings accumulator forward compatible with ComplexType accumulator, namely functions extract/addValues.
Differential Revision: D69204449