Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(fuzzer): Rename ArgGenerator and argsOverrideFuncs to ArgTypesGenerator and argValuesGenerators #12283

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kagamiori
Copy link
Contributor

Summary: Rename ArgGenerator and argsOverrideFuncs used in expression fuzzer to ArgTypesGenerator and argValuesGenerators to differentiate generators for types and values of arguments.

Differential Revision: D69286324

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 7, 2025
Copy link

netlify bot commented Feb 7, 2025

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 68ccf9d
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/67a65e20b7f4f400088ab984

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69286324

Summary:
Make expression fuzzer generate input vectors of valid JSON strings for the
json_parse function. To test corner cases, the JSON strings may be
randomly truncated or inserted with a space character.

Differential Revision: D67820571
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69286324

kagamiori added a commit to kagamiori/velox that referenced this pull request Feb 7, 2025
…nerator and argValuesGenerators (facebookincubator#12283)

Summary:
Pull Request resolved: facebookincubator#12283

Rename ArgGenerator and argsOverrideFuncs used in expression fuzzer to ArgTypesGenerator and argValuesGenerators to differentiate generators for types and values of arguments.

Differential Revision: D69286324
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69286324

kagamiori added a commit to kagamiori/velox that referenced this pull request Feb 7, 2025
…nerator and argValuesGenerators (facebookincubator#12283)

Summary:
Pull Request resolved: facebookincubator#12283

Rename ArgGenerator and argsOverrideFuncs used in expression fuzzer to ArgTypesGenerator and argValuesGenerators to differentiate generators for types and values of arguments.

Differential Revision: D69286324
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69286324

kagamiori added a commit to kagamiori/velox that referenced this pull request Feb 7, 2025
…nerator and argValuesGenerators (facebookincubator#12283)

Summary:
Pull Request resolved: facebookincubator#12283

Rename ArgGenerator and argsOverrideFuncs used in expression fuzzer to ArgTypesGenerator and argValuesGenerators to differentiate generators for types and values of arguments.

Differential Revision: D69286324
…nerator and argValuesGenerators (facebookincubator#12283)

Summary:
Pull Request resolved: facebookincubator#12283

Rename ArgGenerator and argsOverrideFuncs used in expression fuzzer to ArgTypesGenerator and argValuesGenerators to differentiate generators for types and values of arguments.

Differential Revision: D69286324
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69286324

Copy link
Contributor

@kevinwilfong kevinwilfong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this is much clearer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants