fix: Hive unit test flushPolicyWithParquet#16304
Closed
PingLiuPing wants to merge 1 commit intofacebookincubator:mainfrom
Closed
fix: Hive unit test flushPolicyWithParquet#16304PingLiuPing wants to merge 1 commit intofacebookincubator:mainfrom
PingLiuPing wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
Collaborator
Author
wecharyu
approved these changes
Feb 9, 2026
Contributor
wecharyu
left a comment
wecharyu
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix.
Yuhta
approved these changes
Feb 9, 2026
Yuhta
added
the
ready-to-merge
Collaborator
Author
|
@xiaoxmeng Could you please help to import this PR, this PR fixes the CI failure. Thank you. |
|
@jainxrohit has imported this pull request. If you are a Meta employee, you can view this in D93154684. |
Contributor
|
@PingLiuPing Can you rebase to latest main ? The failures in CI should go away. |
Collaborator
Author
|
@kgpai Thanks, I noticed the PR that introduces the failure has been reverted. Let's me close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix hive UT error https://github.com/facebookincubator/velox/actions/runs/21786681207/job/62859220521?pr=16295
/home/runner/work/velox/velox/velox/./velox/dwio/parquet/writer/arrow/Properties.h:407: Check failed: (maxRowGroupBytes) > (0) maxRowGroupBytes must be positive