improve: Stale container cleanup, fail-fast parent selection, post-compilation smoke test

generate_loop.py

@@ -36,6 +36,7 @@
     get_score,
     load_archive_data,
     run_commands_to_check_compilation,
+    run_smoke_test,
     select_parent,
     setup_initial_gen,
     update_and_save_archive,
@@ -151,14 +152,60 @@ def select_next_parent_container(
         exec_result = container.exec_run(cmd=command, workdir=f"/{REPO_NAME}")
         log_container_output(exec_result, verbose=True)
 
+        # Fail-fast on deterministic script errors (won't succeed on retry)
+        if exec_result.exit_code != 0:
+            output_text = (
+                exec_result.output.decode()
+                if exec_result.output else ""
+            )
+            output_lower = output_text.lower()
+            _deterministic_markers = [
+                "syntaxerror", "syntax error",
+                "importerror", "import error", "no module named",
+                "nameerror", "name error",
+                "attributeerror", "attribute error",
+                "typeerror", "type error",
+                "indentationerror", "indentation error",
+                "traceback (most recent call last)",
+            ]
+            if any(marker in output_lower for marker in _deterministic_markers):
+                raise RuntimeError(
+                    "Deterministic script failure"
+                    " in select_next_parent"
+                    f" (exit code"
+                    f" {exec_result.exit_code}):"
+                    f" {output_text[-500:]}"
+                )
+
         # Get next parent outputs
         container_output_strings = exec_result.output.decode().strip().split("\n")
         next_parent_genid = container_output_strings[-1]
-        next_parent_genid = int(next_parent_genid) if not is_starting_node(next_parent_genid) else next_parent_genid
+        if not is_starting_node(next_parent_genid):
+            next_parent_genid = int(next_parent_genid)
+
+    except RuntimeError as e:
+        # Deterministic errors — do not retry
+        safe_log(
+            "Deterministic error in"
+            " select_next_parent_container,"
+            f" not retrying: {e}"
+        )
+        update_node_metadata(
+            generate_output_dir, latest_node,
+            {"can_select_next_parent": False},
+        )
+        next_parent_genid = None
+        max_attempts = 0  # Prevent retry below
 
     except Exception as e:
-        safe_log(f"Error in select_next_parent_container: {e}")
-        update_node_metadata(generate_output_dir, latest_node, {"can_select_next_parent": False})
+        safe_log(
+            "Error in"
+            f" select_next_parent_container: {e}"
+        )
+        update_node_metadata(
+            generate_output_dir, latest_node,
+            {"can_select_next_parent": False},
+        )
         next_parent_genid = None
 
     # Even on errors or KeyboardInterrupt
@@ -617,6 +664,17 @@ def generate(
             # Run commands to check if the agents are compilable
             run_commands_to_check_compilation(container, run_baseline=run_baseline, edit_select_parent=edit_select_parent)
 
+            # Lightweight smoke test post-compilation
+            if not run_smoke_test(container):
+                safe_log(
+                    "Smoke test failed: TaskAgent"
+                    " not instantiable or forward()"
+                    " signature invalid."
+                    " Skipping evaluation."
+                )
+                run_eval = False
+                metadata["run_eval"] = False
+
         # Evaluate the produced agent
         if run_eval and "agent" in optimize_option:
             log_path = os.path.join(gen_output_dir, "generate.log")
@@ -739,6 +797,19 @@ def generate_loop(
 ):
     # Initialization
     docker_client = docker.DockerClient()
+
+    # Clean up orphaned containers from previous crashed runs
+    try:
+        for c in docker_client.containers.list(all=True):
+            if c.name and c.name.startswith(f"{REPO_NAME}-"):
+                try:
+                    safe_log(f"Removing orphaned container: {c.name}")
+                    c.remove(force=True)
+                except Exception:
+                    pass  # Best-effort cleanup
+    except Exception:
+        pass  # Don't block the main loop if cleanup fails
+
     parent_selection = "latest" if run_baseline == "no_archive" else parent_selection
     if resume_from:
         output_dir = os.path.normpath(os.path.abspath(resume_from))

tests/conftest.py

@@ -0,0 +1,188 @@
+"""Shared fixtures for HyperAgents test suite."""
+
+import importlib
+import importlib.util
+import os
+import json
+import sys
+import tempfile
+import shutil
+import types
+
+import pytest
+
+# ---- Project root on sys.path ----
+_PROJ = os.path.normpath(
+    "C:/Users/ryuke/Desktop/Projects/Hyperagents"
+)
+if _PROJ not in sys.path:
+    sys.path.insert(0, _PROJ)
+
+
+def _install_lightweight_mocks():
+    """Install minimal mock modules so that project
+    modules can be imported without heavy deps like
+    docker, litellm, backoff, torch, etc.
+
+    Only installs mocks for modules NOT already
+    present -- safe to call multiple times.
+    """
+    def _ensure(name, factory):
+        if name not in sys.modules:
+            sys.modules[name] = factory()
+
+    # docker
+    _ensure("docker", lambda: types.ModuleType("docker"))
+
+    # utils.docker_utils
+    def _make_docker_utils():
+        m = types.ModuleType("utils.docker_utils")
+        m.copy_to_container = lambda *a, **k: None
+        m.log_container_output = lambda *a, **k: None
+        return m
+    _ensure("utils.docker_utils", _make_docker_utils)
+
+    # utils.git_utils
+    def _make_git_utils():
+        m = types.ModuleType("utils.git_utils")
+        m.commit_repo = lambda *a, **k: "abc123"
+        m.get_git_commit_hash = lambda *a, **k: "abc"
+        return m
+    _ensure("utils.git_utils", _make_git_utils)
+
+    # backoff
+    def _make_backoff():
+        m = types.ModuleType("backoff")
+        m.expo = "expo"
+        m.on_exception = (
+            lambda *a, **kw: (lambda f: f)
+        )
+        return m
+    _ensure("backoff", _make_backoff)
+
+    # requests / requests.exceptions
+    def _make_requests():
+        m = types.ModuleType("requests")
+        exc = types.ModuleType("requests.exceptions")
+        exc.RequestException = Exception
+        m.exceptions = exc
+        sys.modules["requests.exceptions"] = exc
+        return m
+    _ensure("requests", _make_requests)
+
+    # litellm
+    def _make_litellm():
+        m = types.ModuleType("litellm")
+        m.drop_params = True
+        m.completion = lambda **kw: None
+        return m
+    _ensure("litellm", _make_litellm)
+
+    # dotenv
+    def _make_dotenv():
+        m = types.ModuleType("dotenv")
+        m.load_dotenv = lambda *a, **kw: None
+        return m
+    _ensure("dotenv", _make_dotenv)
+
+    # utils.thread_logger
+    def _make_thread_logger():
+        m = types.ModuleType("utils.thread_logger")
+        class FakeLM:
+            def __init__(self, **kw):
+                self.log = print
+        m.ThreadLoggerManager = FakeLM
+        return m
+    _ensure(
+        "utils.thread_logger", _make_thread_logger
+    )
+
+    # tqdm (used by genesis evaluator)
+    def _make_tqdm():
+        m = types.ModuleType("tqdm")
+        m.tqdm = lambda *a, **kw: iter([])
+        return m
+    _ensure("tqdm", _make_tqdm)
+
+    # pandas (used by ensemble.py)
+    def _make_pandas():
+        m = types.ModuleType("pandas")
+        m.read_csv = lambda *a, **kw: None
+        return m
+    _ensure("pandas", _make_pandas)
+    _ensure("pd", _make_pandas)
+
+
+# Install mocks at import time so all test modules
+# benefit.
+_install_lightweight_mocks()
+
+
+def load_module_from_file(module_name, file_path):
+    """Load a Python module directly from a file path,
+    bypassing package __init__.py files.
+
+    Useful for modules whose package __init__ imports
+    heavy deps (e.g., torch).
+    """
+    abs_path = os.path.join(_PROJ, file_path)
+    spec = importlib.util.spec_from_file_location(
+        module_name, abs_path
+    )
+    mod = importlib.util.module_from_spec(spec)
+    sys.modules[module_name] = mod
+    spec.loader.exec_module(mod)
+    return mod
+
+
+@pytest.fixture
+def tmp_dir():
+    """Provide a temporary directory, cleaned up after test."""
+    d = tempfile.mkdtemp()
+    yield d
+    shutil.rmtree(d, ignore_errors=True)
+
+
+@pytest.fixture
+def sample_archive_jsonl(tmp_dir):
+    """Create a sample archive.jsonl file with valid data."""
+    path = os.path.join(tmp_dir, "archive.jsonl")
+    entries = [
+        {
+            "current_genid": 0,
+            "archive": [0],
+        },
+        {
+            "current_genid": 1,
+            "archive": [0, 1],
+        },
+        {
+            "current_genid": 2,
+            "archive": [0, 1, 2],
+        },
+    ]
+    with open(path, "w") as f:
+        for entry in entries:
+            f.write(json.dumps(entry) + "\n")
+    return path
+
+
+@pytest.fixture
+def sample_metadata_dir(tmp_dir):
+    """Create gen_X directories with metadata.json files."""
+    for genid in range(3):
+        gen_dir = os.path.join(
+            tmp_dir, f"gen_{genid}"
+        )
+        os.makedirs(gen_dir, exist_ok=True)
+        metadata = {
+            "parent_genid": genid - 1 if genid > 0 else None,
+            "valid_parent": True,
+            "prev_patch_files": [],
+            "curr_patch_files": [],
+        }
+        with open(
+            os.path.join(gen_dir, "metadata.json"), "w"
+        ) as f:
+            json.dump(metadata, f)
+    return tmp_dir