[bugfix] Fix distillation from unsharded teacher checkpoint #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
MichaelRamamonjisoa
approved these changes
Oct 21, 2025
Contributor
MichaelRamamonjisoa
left a comment
MichaelRamamonjisoa
left a comment
There was a problem hiding this comment.
Tested, LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We were not passing process group when loading teacher checkpoints for distillation and this caused a bug when distilling from unsharded checkpoints. This PR fixes that.
Test plan
Tested with the multi-distillation example run from README and verified that we can load unsharded as well as sharded checkpoints for distillation