-
-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optuna resume study #2647
base: main
Are you sure you want to change the base?
Optuna resume study #2647
Conversation
Could somebody help me understand the errors? I am not sure how to fix my code in order to have it pass the tests. |
There's an annoying issue that hasn't been fixed yet in master that's adding noise to the tests. Can you include the fix from #2731 in your PR, which hopefully will clean up the CI logs? |
Thanks, it doesn't seem to help though. |
Hmm, yeah there are a bunch of errors that seem unlikely to have anything to do with your PR. I'm afraid CI is currently broken. |
Okay, thanks for confirming. I'll hope someone will review and accept this anyway. |
Motivation
When using the Optuna sweeper and the
storage
option, theoptuna.study
will actually be resumed (ref).However, the sweeper will reset the
job_idx
to 0 and then_trials_to_go
to the number originally configured (i.e., before interrupting the sweep).It's confusing that the reloading is done but the configured job parameters are not updated. This PR makes it explicit by allowing the configuration of the
load_if_exists
parameter. IfTrue
(by default - for strongest backwards compatibility) the study is loaded if it already exists. Then_trials_to_go
andjob_idx
are then updated accordingly. IfFalse
, an Optuna error will be raised. Note this parameter acts exactly in accordance with optuna.Have you read the Contributing Guidelines on pull requests?
Yes, but it's my first contribution so any feedback is welcome.
Test Plan
I added an additional test to demonstrate and test the desired behavior.
Related Issues and PRs
This is related to #1407 and should close #1679. (W.r.t. #1679 the garbage collecting can be done in a callback, I can optionally demonstrate in that issue before it's closed).