Extend list function #2950
Merged
Extend list function #2950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
yikaiMeta
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#1547
There is currently no clean way to append to a list using the override syntax. It was suggested in the above issue that this could be done by adding a custom function, so that's what this PR does. It means that if the config is:
composing the config with this as an override:
extras.tags="extend_list(another_tag, yet_another_tag)"would generate
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Added unit tests that pass, also checked the added documentation looks correct using yarn start
Related Issues and PRs
#1547