Skip to content

Fix hardcoded CUDA devices and pin_memory when running on CPU - #637

Open
mschweig wants to merge 1 commit into
facebookresearch:mainfrom
mschweig:mschweiger/fix-cpu-device-init
Open

mschweig wants to merge 1 commit into
facebookresearch:mainfrom
mschweig:mschweiger/fix-cpu-device-init

Conversation

@mschweig

Copy link
Copy Markdown

Building the SAM 3 image model with build_sam3_image_model(device="cpu") and running inference on CPU-only machines previously failed because PositionEmbeddingSine and TransformerDecoder hardcoded device="cuda" when precomputing their coordinate and positional encoding caches during initialization, and SequenceGeometryEncoder._encode_boxes unconditionally called .pin_memory() even when input tensors were on CPU.

This change selects "cuda" if torch.cuda.is_available() else "cpu" when precomputing the positional and coordinate caches, ensures cached tensors are moved to the input tensor's device during the forward pass (preventing device mismatches when device="cpu" is used on a CUDA-capable host), and only calls .pin_memory() in _encode_boxes when the box tensor is on CUDA.

@meta-cla

meta-cla Bot commented Oct 21, 2026

Copy link
Copy Markdown

Hi @mschweig!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla

meta-cla Bot commented Oct 21, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant