Comments addressing PR #15 and Issue #65 #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
mmuckley
approved these changes
Aug 19, 2025
Contributor
mmuckley
left a comment
mmuckley
left a comment
There was a problem hiding this comment.
LGTM. Recommend adding a link to the original PR in the comment.
Contributor
Author
done, thank you! submitting now. |
richardhoff88
pushed a commit
to richardhoff88/vjepa2
that referenced
this pull request
Aug 28, 2025
(facebookresearch#75) * Comments addressing PR facebookresearch#15 and Issue facebookresearch#65 * Link to PR facebookresearch#15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15 addresses a bug in our RoPE implementation but would break use with our released models. Add the fix as a comment and credit the submittor.
Issue #65 discusses how to create an index file for droid/robot training--let's add a pointer to it in the .csv (and remove the confusing
_cwsuffix)