Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new: implement build cmd #10

Merged
merged 10 commits into from
Sep 4, 2023
Merged

new: implement build cmd #10

merged 10 commits into from
Sep 4, 2023

Conversation

FedeDP
Copy link
Collaborator

@FedeDP FedeDP commented Sep 1, 2023

  • initial impl for build cmd; we miss some driverkit changes
  • move driver-name to root options and support it in cleanup and stats
  • dropped CleanupAll interface method
  • some refactors

FedeDP
FedeDP commented Sep 1, 2023
View reviewed changes
pkg/utils/s3/s3utils.go
return object != nil
}

func (cl *Client) PutObject(opts root.Options, driverVersion, key string, reader io.Reader) error {
Copy link
Collaborator Author

@FedeDP FedeDP Sep 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metadata were taken by:

aws s3api head-object --bucket falco-distribution --key driver/5.0.1+driver/x86_64/falco_amazonlinux_4.9.85-38.58.amzn1.x86_64_1.ko --no-sign-request
{
    "AcceptRanges": "bytes",
    "LastModified": "Mon, 28 Aug 2023 14:17:28 GMT",
    "ContentLength": 3391880,
    "ETag": "\"eaa1285b6a5271da093203acabde4467\"",
    "ContentType": "binary/octet-stream",
    "ServerSideEncryption": "AES256",
    "Metadata": {}
}

@FedeDP
Copy link
Collaborator Author

FedeDP commented Sep 1, 2023

CI will be broken right now since build_test is broken.

@FedeDP FedeDP merged commit d23e083 into main Sep 4, 2023
1 check passed
@FedeDP FedeDP deleted the new/build_cmd branch September 4, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@FedeDP