Repository navigation
fix(examples): always-show contributions; keep settings rows presentational - #318
Merged
Merged
Conversation
…ons always Example settings exist to demonstrate the typed-settings plumbing in the Mods menu, not to gate the very contribution the examples are there to show. The tooltip annotations and the extra tractor beam are now always active so they are observable on first load; AnnotateModules and ExtraAutoBeam remain as presentation-only rows. E2E asserts the rows gate nothing (annotations render and borrowing happens with the row both ways). Live: ui-surfaces and equipment-targeting pass, saves unchanged, install restored.
fank
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Owner review of the deployed examples: the examples gated their own showcase behind
default-off settings (
AnnotateModules,ExtraAutoBeam), so a fresh install showedno tooltips and no beam at all. Example settings exist to demonstrate the typed-settings
plumbing in the Mods menu, not to hide the surface under review.
Change
UiSurfaces: ship-module stat line and Engineering mastery badge line are registeredunconditionally and always render;
AnnotateModulesstays as a presentation-only row.EquipmentTargeting: the extra-beam policy is always active (spare-manual-beameligibility still abstains by null);
ExtraAutoBeamis a presentation-only row.both ways (the row gates nothing).
The StationCommerce item tip was already unconditional and is unchanged.
Verification
Live (this code, qualified 0.8.2.4 build):
ui-surfacesandequipment-targetingpass (
artifacts/e2e/presentation-ui-2,presentation-et-1;realSavesUnchanged,installationRestored). Host suite 1835 green on this branch.Split out of the #312 branch at the owner's request; #312 is back to pickup-only scope.