Skip to content

Fix incomplete directory cleanup on scaffolding failure #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
err0rgod wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix incomplete directory cleanup on scaffolding failure #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions src/fastapi_new/new.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,18 +196,27 @@ def new(
"uv is required to create new projects. Install it from https://docs.astral.sh/uv/getting-started/installation/",
)

_setup(toolkit, config)
try:
_setup(toolkit, config)

toolkit.print_line()

_install_dependencies(toolkit, config)
toolkit.print_line()

toolkit.print_line()
_install_dependencies(toolkit, config)

_write_template_files(toolkit, config)
toolkit.print_line()

toolkit.print_line()
_write_template_files(toolkit, config)

toolkit.print_line()
except typer.Exit as e:
# if we create a new directory and error occured, clean it up
if not current_dir and config.path.exists():
shutil.rmtree(config.path, ignore_errors=True)
toolkit.print(
"[yellow]Cleaned up incomplete directory[/yellow]"
)
# re raising the exit so the program still terminates properly
raise e
# Print success message
if not current_dir:
toolkit.print(
Expand Down
Loading