Support aliased FastAPI and APIRouter imports#104
Closed
Ashif4354 wants to merge 1 commit intofastapi:mainfrom
Closed
Support aliased FastAPI and APIRouter imports#104Ashif4354 wants to merge 1 commit intofastapi:mainfrom
Ashif4354 wants to merge 1 commit intofastapi:mainfrom
Conversation
Member
|
Hey there - thanks for opening this! However, I ended up refactoring the extractors quite substantially in #107 to address a few other issues and ended up fixing this as well. Appreciate the PR though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extension could not find the FastAPI app if it was imported with an alias (for example, from fastapi import FastAPI as FA). The discovery logic only looked for the exact text "FastAPI(". This caused the extension to completely miss valid applications that used different naming styles.
So updated the discovery process and the parser so the extension can now understand and detect aliased imports.
This fixes #102