🐛 Fix incorrect selection of root when app and router defined in same file#9
Merged
savannahostrowski merged 4 commits intomainfrom Jan 14, 2026
Merged
🐛 Fix incorrect selection of root when app and router defined in same file#9savannahostrowski merged 4 commits intomainfrom
savannahostrowski merged 4 commits intomainfrom
Conversation
Member
|
💯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7
This PR addresses a bug where we were incorrectly selecting the wrong root instead of the FastAPI app when both were in the same file.
The fix here is to prioritize FastAPI apps over APIRouter for parent selection, filter routers by owners (e.g. app or router; note that this is currently called
objectonRouteInfoand I will rename accordingly in a follow up PR), and then explicitly check if router is defined locally in the same file when resolving include_router before looking for imports.I've also added a new fixture to handle this case.