Skip to content

Fix duplicated words in virtual environment documentation#1885

Closed
dhruvatr wants to merge 1 commit into
fastapi:masterfrom
dhruvatr:patch-1
Closed

Fix duplicated words in virtual environment documentation#1885
dhruvatr wants to merge 1 commit into
fastapi:masterfrom
dhruvatr:patch-1

Conversation

@dhruvatr

@dhruvatr dhruvatr commented Jul 7, 2026

Copy link
Copy Markdown

Pull Request

Discussion:

Description

AI Disclaimer

AI transcript

Checklist

  • This PR links to a GitHub Discussion for the proposed code change.

  • I added tests for the change.

  • The new or updated tests fail on the main branch and pass on this PR.

  • Coverage stays at 100%.

  • The documentation explains the change if needed.

  • Remove duplicated words ("looking first look") in two PATH variable explanations.

  • Improve readability by correcting the sentence to "start looking for programs in:".

  • No functional changes.

@github-actions github-actions Bot added the docs Improvements or additions to documentation label Jul 7, 2026
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

@phalberg

phalberg commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Hey, I am no maintainer,
but obvious typos are now added to a main thread (see previous message for a similar PR fix from a maintainer below):

We're no longer accepting single-typo PRs as this creates too much maintenance burden for little gain. Instead, I've added this to the main thread #1862 which we'll be using to collect these. We'll be updating the guidelines around this as well. Thanks 🙏

I have added a message about it in that thread.

One thing to note:

  • Is it rather "a system will now start looking firstly for programs in (...)" ? Not sure, I will leave that up to maintainers to judge, based on how important that wording is.

But nonetheless I do agree that a typo here is present, thanks for the PR!

@svlandeg svlandeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing & merging with the typo thread, cf what @phalberg said 🙏

@svlandeg svlandeg closed this Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants