Fix atomic writes replacing destinations after command failures - #1918
Open
wterrr wants to merge 1 commit into
Open
Fix atomic writes replacing destinations after command failures#1918wterrr wants to merge 1 commit into
wterrr wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
File parameters configured with
atomic=Truereplace the destination evenwhen the command callback raises an exception after writing partial content.
This defeats the purpose of atomic output and can replace an existing valid
file with incomplete data.
The issue affects both
lazy=Trueandlazy=False.Fix
Atomic files are now registered with
Context.with_resource()so theircontext managers receive the active exception.
LazyFileforwards the exception information to its underlying atomicstream, and
_AtomicFile.close(delete=True)removes the temporary fileinstead of replacing the destination.
Non-atomic file cleanup behavior is unchanged.
Tests
Regression coverage verifies both lazy modes when:
Validation results:
Related upstream report: pallets/click#3221