✨ Handle archive size limit - #305
Merged
Merged
Conversation
patrick91
reviewed
Jul 28, 2026
patrick91
left a comment
patrick91
left a comment
Member
There was a problem hiding this comment.
Do we need to put the new status here too?
| archive_size_bytes=archive_size, | ||
| ) | ||
| except ArchiveTooLargeError as e: | ||
| _fail_archive_too_large(toolkit, progress, str(e)) |
Member
There was a problem hiding this comment.
see the comment above, with toolkit.fail we can probably remove this floating function
Comment on lines
+46
to
+53
| def _get_s3_error_code(response: Response) -> str | None: | ||
| """Extract the error code from an S3 XML error response.""" | ||
| try: | ||
| root = ET.fromstring(response.text) | ||
| except ET.ParseError: | ||
| return None | ||
|
|
||
| return root.findtext("Code") |
Member
There was a problem hiding this comment.
not a big fan of having S3 specific things here, could we avoid it?
(not sure if it is even worth handling this error directly, since it shouldn't ever happen)
patrick91
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.