Verify pipeline patch#30
Conversation
|
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
| @@ -49,6 +49,9 @@ | |||
| "outputs": [], | |||
There was a problem hiding this comment.
The verify_pipeline function defined here should be instead on the Pipelines section, that is a couple of cells below. Also, it would be very helpful to include some examples, and you can add tests that it works using test_warns function from fastcore.
Reply via ReviewNB
|
The tests are breaking because of a problem while exporting the code from the notebooks. Please follow the instructions to fix it:
pip install nbdev --upgrade
nbdev_clean_nbs
nbdev_build_lib
nbdev_build_docs
The instructions to contribute that are present on the repository at the moment are lacking, I will update them. |
Surely we ca add those the into the pre-commit hook? |
The verify_pipeline method covers the known edge-cases for the transforms pipeline. The design is to introduce an extensible framework to check future cases.