Skip to content

Update fastai dependency#49

Open
tyoc213 wants to merge 3 commits into
fastaudio:masterfrom
tyoc213-contrib:fastai_update
Open

Update fastai dependency#49
tyoc213 wants to merge 3 commits into
fastaudio:masterfrom
tyoc213-contrib:fastai_update

Conversation

@tyoc213

@tyoc213 tyoc213 commented Aug 27, 2020

Copy link
Copy Markdown

Now fastai2 is just fastai

@tyoc213

tyoc213 commented Aug 27, 2020

Copy link
Copy Markdown
Author

I didnt do nbdev_build_docs because I see more changes that just the lines of fastai2 to fastai.

Also there are some test that dont past inside fastcore it seems?

@kevinbird15

Copy link
Copy Markdown

I see the same issue with the warning test failing. I can't figure out what that should be producing. Any idea what those commands should produce?

@tyoc213

tyoc213 commented Aug 28, 2020

Copy link
Copy Markdown
Author

@kevinbird15 dont know, will check tomorrow, today I just updated the example to use the dataset from pytorch voice comands, hope people dont mind.

@tyoc213

tyoc213 commented Aug 28, 2020

Copy link
Copy Markdown
Author

By the way, in the tutorial I need to change batch sizes from 512 and 1024 to 64, dont know if the last one I can put a bigger size, didnt try.

@hellno

hellno commented Sep 5, 2020

Copy link
Copy Markdown

Hi, would love to help with this. What is left to do to merge it to master?

@mogwai

mogwai commented Sep 5, 2020

Copy link
Copy Markdown
Member

We're going for restructure of the project without nbdev. They new project can be found here:

https://github.com/fastaudio/fastaudio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants