Repository navigation
Conversation
Signed-off-by: zengks <zengks@outlook.com>
|
Tested locally on Node 24 (Windows). All 5 tests in est/watch.test.js pass cleanly and The regex (?:^|[/\\])\.git(?:[/\\]|$) handles Windows drive paths (C:\work\app.git\HEAD) and UNC network shares (\server\share\app.git\HEAD) while allowing projects in .git-suffixed folders (such as ordinary.git or worktrees) to trigger watch reloads. Custom ignore expressions also retain their existing behavior. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default
.gitignore matches substrings anywhere in an absolute path. In directories such asfastify.git/mainorordinary.git, TypeScript recompiles but Fastify does not restart because the watcher ignores the app.Match the literal
.gitentry as a complete path segment using POSIX or Windows separators. Git metadata files, directories, and descendants remain excluded. Other ignore tokens and custom regular expressions retain their existing behavior.Add regression tests for metadata exclusion, similarly named directories, Windows drive and UNC paths, parsed TypeScript watch defaults, and custom expressions. Document the corrected behavior.
Fixes #548.
Validation
npm run benchmark --if-presentsucceeds; no benchmark script is defined.Related: #925 changes
buildmatching in the same helper. This change is limited to the literal.gittoken.Checklist
npm run test && npm run benchmark --if-present