Repository navigation
fix: skip production build before CommonJS TypeScript tests - #933
Open
pillaiajay31 wants to merge 3 commits into
Open
pillaiajay31 wants to merge 3 commits into
pillaiajay31 wants to merge 3 commits into
Conversation
Remove the production build step from the generated CommonJS TypeScript test script. The test helper loads src/app.ts directly through ts-node, and the test TypeScript configuration already checks the application source without emitting files. Signed-off-by: Ajay Pillai <pillaiajay42@gmail.com>
Signed-off-by: AJAY PILLAI <pillaiajay42@gmail.com>
Signed-off-by: AJAY PILLAI <pillaiajay42@gmail.com>
pillaiajay31
force-pushed
the
fix/640-typescript-test-build
branch
from
November 11, 2026 05:41
e2a27b7 to
c0781bc
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the redundant production build before testing generated CommonJS TypeScript apps. Keep source type checking and tests through ts-node, and preserve the independent production build.
Update the CommonJS template for TypeScript 6 with explicit Node types and rootDir settings, remove the unused baseUrl, update generator assertions, and document test/build behavior.
Fixes #640.
Validation on Windows with Node.js v24.22.1 and TypeScript 6.0.3:
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct