Skip to content

chore: move mongodb as peer dependency #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rtritto
Copy link

@rtritto rtritto commented Sep 17, 2024

Fastify v5 is released

Checklist

@rtritto
Copy link
Author

rtritto commented Sep 17, 2024

FYI @gurgunday

Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, but peer dependencies cause more problems than they solve. We prefer to avoid them.

@rtritto
Copy link
Author

rtritto commented Sep 17, 2024

As standard, all plugins use peer dependencies because a specific version can be selected.

@Eomm
Copy link
Member

Eomm commented Sep 18, 2024

In these duplicates, you can find the workaround:

fastify/fastify-swagger#220
fastify/fastify-static#159

The decision has been to don't add it as peerDependencies.

Since npm v10 has been released, we should re-evaluate it: would you like to analyze if it is doable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants