Fix: Correct AsyncLocalStorage type parameter to match actual store #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RequestContextData) The AsyncLocalStorage was incorrectly typed as RequestContext, but in reality it stores RequestContextData, which is directly accessed via key-value operations (e.g. store[key]). Signed-off-by: Gleb <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a type inconsistency in the AsyncLocalStorage type parameter. The AsyncLocalStorage was incorrectly typed as storing RequestContext when it actually stores RequestContextData.
- Corrects the AsyncLocalStorage type parameter from
RequestContexttoRequestContextData - Updates type test to properly validate the AsyncLocalStorage stores RequestContextData
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Correct AsyncLocalStorage type parameter to match actual store (RequestContextData)
The AsyncLocalStorage was incorrectly typed as RequestContext, but in reality it stores RequestContextData, which is directly accessed via key-value operations (e.g. store[key]).
Checklist
npm run testandnpm run benchmarkand the Code of conduct