fix cls threhsold not being used - #92
Open
MauroCE wants to merge 1 commit into
Open
Conversation
Collaborator
this was intended, in general single label classification uses argmax decoding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #66
cls_thresholdwas being read but never actually used in single-label classification. The top label was always returned regardless of its score. Also removed the multi-label fallback that had the same problem, where if nothing passed the threshold it would return the best label anyway. Both paths now returnNoneor[]when nothing meets the threshold. Happy to adjust the return values if something different is preferred