API キーを Client の初期化時に渡せるように修正 #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
今までは環境変数経由でしか渡せなかったAPIキーを、Client の初期化時にも渡せるように修正しました。
両方から渡された場合は初期化時のAPIキーが使われます。
今までは環境変数経由のみだったため、別のAPIキーを使い分けるケース（ワークスペースを跨いだ処理）では環境変数を変えてClient を作り直す、などの複雑なことをしないといけませんでした。
今回のこの処理で、コンストラクト時に渡せるようになるので、シンプルになります。
↓藤繁さんからも、賛同いただいています。
https://fastlabel.slack.com/archives/C058HK65BND/p1750818698971999?thread_ts=1750817885.721389&cid=C058HK65BND