Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for launch images for android #54

Conversation

RishabhTayal
Copy link
Contributor

fixes: #53

@josh-m-sharpe
Copy link
Contributor

Probably fixes #49 too

@josh-m-sharpe
Copy link
Contributor

josh-m-sharpe commented Sep 8, 2019

@RishabhTayal Couple of thoughts here:

  1. There's no README update
  2. From the code it doesn't look like it supports both portrait and landscape images
  3. "launch_image" seems too similar to "launcher" - Why not use "splash" instead?

@josh-m-sharpe
Copy link
Contributor

josh-m-sharpe commented Sep 8, 2019

Forcibly resizing the image is probably not a good idea either since the final sizes are all different ratios. You probably want to resize the image to a square and then trim in the sides - that would at least keep the aspect ratio of the original image correct.

@josh-m-sharpe
Copy link
Contributor

Yea - if you remove the ! here: https://github.com/KrauseFx/fastlane-plugin-appicon/pull/54/files#diff-d29e0527a6452a0d57b299118a56018fR64 then aspect ratio is preserved. I suspect most users would prefer it that way.

@ssilverr
Copy link

Any news on this?

@joshdholtz
Copy link
Member

Closed due to #54

@joshdholtz joshdholtz closed this Apr 27, 2020
@ssilverr
Copy link

@joshdholtz this is #54. Did you mean #56 ?

@joshdholtz
Copy link
Member

lol I did 😝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for launch images
4 participants