allow AWS_SESSION_TOKEN to create session token #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joohae-kim
commented
Sep 21, 2021
| @@ -89,7 +91,7 @@ def self.run(config) | |||
| client_cfg[:region] = s3_region if s3_region | |||
| client_cfg[:endpoint] = s3_endpoint if s3_endpoint | |||
| client_cfg[:profile] = s3_profile if s3_profile | |||
| client_cfg[:credentials] = Aws::Credentials.new(s3_access_key, s3_secret_access_key) if s3_access_key && s3_secret_access_key | |||
| client_cfg[:credentials] = Aws::Credentials.new(s3_access_key, s3_secret_access_key, s3_session_token) if s3_access_key && s3_secret_access_key | |||
There was a problem hiding this comment.
https://docs.aws.amazon.com/sdk-for-ruby/v2/api/Aws/Credentials.html
the default value of the session token field is null, hence it should be okay
|
@joohae-kim I've tested your PR and it seems like working fine. |
|
@joshdholtz bump |
|
@joshdholtz this feature could be really helpful for AWS Federated Logins 👍 |
|
+1, we just ran into this as well. We use SAML-federated logins to AWS, so all of our development credentials require |
joshdholtz
approved these changes
Mar 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for me, it's not easy to explaining the detail why I wanted merge the update into the main repo
however, I think we can use AWS_SESSION_TOKEN variable with simple touch up
please, refer following issue ticket
thank you
Reference: #54