Apply clippy fixes and code improvements

[devin-ai-integration]

Summary

This PR applies various clippy-suggested fixes across the codebase, improving code quality and idiomatic Rust usage. Changes include:

• Replace manual min/max chains with clamp() for cleaner bounds checking
• Use while let instead of loop { match ... } patterns
• Mark extern C functions that dereference raw pointers as unsafe
• Remove redundant field initialization (speaker: speaker → speaker)
• Use is_multiple_of() instead of modulo comparison
• Collapse nested if let patterns where appropriate
• Remove unnecessary .into() and borrow operations
• Use unwrap_or_default() instead of match on Result

Updates since last revision

• Fixed platform-specific build failure: Restored mut keyword on builder variable in plugins/windows/src/window/v1.rs with #[allow(unused_mut)]. The variable is reassigned in #[cfg(target_os = "macos")] and #[cfg(target_os = "windows")] blocks, so mut is required on those platforms even though clippy on Linux suggested removing it.

Review & Testing Checklist for Human

• Verify the unsafe marking on rust_on_notification_confirm and rust_on_notification_dismiss in notification-macos/src/lib.rs - These extern C functions now require unsafe to call from Rust. Confirm no Rust code calls these directly (they appear to be callbacks from Swift/ObjC).
• Verify clamp() behavior matches original min/max chains - The semantic should be identical, but worth a quick sanity check on audio-utils and transcribe-moonshine changes.
• Test transcription services - The transcribe-deepgram service had its nested if-let patterns collapsed; verify Deepgram transcription still works correctly.

Recommended test plan: Run the desktop app locally with ONBOARDING=0 pnpm -F desktop tauri dev and test a recording session to verify transcription functionality is unaffected.

Notes

• These changes were primarily auto-applied via cargo clippy --fix with some manual adjustments
• macOS-specific crates (notification-macos, notch, tcc) couldn't be fully compiled on Linux, but the changes are straightforward
• Platform-specific code paths (like the builder variable in windows plugin) required special handling since clippy on Linux doesn't see the cfg-gated reassignments
• Remaining clippy warnings are mostly about unused code or complex types that would require more significant refactoring

Link to Devin run: https://app.devin.ai/sessions/ccbfa3019f6445cdaae0f2c3dc33bbf2
Requested by: unknown ()

[devin-ai-integration]

Prompt hidden (unlisted session)

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
• Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

• Disable automatic comment and CI monitoring

[netlify]

✅ Deploy Preview for hyprnote ready!

Name	Link
🔨 Latest commit	6a593f3
🔍 Latest deploy log	https://app.netlify.com/projects/hyprnote/deploys/6925b3330a08f80008e83f4c
😎 Deploy Preview	https://deploy-preview-1890--hyprnote.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch devin/1764075980-clippy-fixes

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[netlify]

✅ Deploy Preview for hyprnote-storybook ready!

Name	Link
🔨 Latest commit	6a593f3
🔍 Latest deploy log	https://app.netlify.com/projects/hyprnote-storybook/deploys/6925b3336328cb0008d3fd25
😎 Deploy Preview	https://deploy-preview-1890--hyprnote-storybook.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.