Sync Agents to Console#837
Open
fathah wants to merge 1 commit into
Open
Conversation
Contributor
Greptile SummaryThis PR adds a profile-level path for syncing agents to Hermes One. The main changes are:
Confidence Score: 5/5This looks safe to merge after a small cleanup to the linked-agent IPC lookup.
src/main/ipc/register.ts Important Files Changed
|
Comment on lines
+843
to
+845
| ipcMain.handle("agent-sync-linked-id", (_event, profile: string) => | ||
| getLinkedAgentId(profile), | ||
| ); |
Contributor
There was a problem hiding this comment.
Invalid Profile Rejects Lookup
When the renderer passes an invalid profile slug such as Default or ../x, this handler forwards it into getLinkedAgentId(), which reaches profile-name normalization and throws. The new Sync pane then gets a rejected IPC call instead of null, so a bad or stale profile value leaves the pane without normal linked/unlinked state.
Suggested change
| ipcMain.handle("agent-sync-linked-id", (_event, profile: string) => | |
| getLinkedAgentId(profile), | |
| ); | |
| ipcMain.handle("agent-sync-linked-id", (_event, profile: string) => { | |
| try { | |
| return getLinkedAgentId(profile); | |
| } catch { | |
| return null; | |
| } | |
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.