fix: aiokafka 0.11.0
error when creating topics
#631
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Before submitting this pull request, please review our contributing
guidelines.
Description
Please note this build wasn't verified on an example Faust app.
Aiokafka introduced
build_request_header
andparse_response_header
calls inconn.py
module in0.11.0
release:aio-libs/aiokafka@a244a5f#diff-60fe72976f73ef2b8b881a26cc5d9e002c465e7b1b7f1b83e0be07c672a66e0e
Use
CreateTopicsRequest
fromaiokafka.protocol.admin
module instead offaust.utils.kafka
.Remove
faust.utils.kafka
module containing what looks like older version of code fromaiokafka.protocol.admin
.Fixes #630
NOTE: All patches should be made against master, not a maintenance branch like
3.1, 2.5, etc. That is unless the bug is already fixed in master, but not in
that version series.
If it fixes a bug or resolves a feature request,
be sure to link to that issue via (Fixes #4412) for example.