chore: added exceptions to be translatable#140
Merged
igobranco merged 4 commits intonau/teak.masterfrom Mar 16, 2026
Merged
Conversation
Tiago-Salles
force-pushed
the
Tiago-Salles/issues/800-translatable-exceptions
branch
2 times, most recently
from
d82a3db to
24d352f
Compare
igobranco
reviewed
Mar 16, 2026
Member
There was a problem hiding this comment.
@Tiago-Salles now you have to translate to Portuguese the strings... on: nau_openedx_extensions/locale/pt_PT/LC_MESSAGES/django.po
Tiago-Salles
force-pushed
the
Tiago-Salles/issues/800-translatable-exceptions
branch
from
24d352f to
06da265
Compare
igobranco
requested changes
Mar 16, 2026
Member
igobranco
left a comment
igobranco
left a comment
There was a problem hiding this comment.
@Tiago-Salles That is not how translations work on Django. We need to talk!
Contributor
Author
This is a very common way of translating in Django, which is inclusively being applied in other filters, such as: Let's talk, as I am not getting what you mean. |
Tiago-Salles
force-pushed
the
Tiago-Salles/issues/800-translatable-exceptions
branch
from
06da265 to
9097e3b
Compare
Tiago-Salles
force-pushed
the
Tiago-Salles/issues/800-translatable-exceptions
branch
from
9097e3b to
808c8f6
Compare
The check missing translations had an issue because the validation wasn't being applied to all languages.
Member
|
@Tiago-Salles Just to let you know, I have added a couple of commits to your branch. To fix the translations CI. |
igobranco
approved these changes
Mar 16, 2026
Member
|
Merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: fccn/nau-technical#800