Allow for timeout if featurehub is unreachable, so we don't block indefinitely #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efinitely. Add tests
Author
|
Full disclosure, I couldn't actually run the tests as I had an issue with groovy and Unsupported class file major version 65. However they should work. |
Contributor
|
ok, i'll take a look, we have a major revision of the Java SDK coming up, so I'll need to pull this change in there as well. |
Contributor
|
The groovy tests are missing some libraries so I slightly re-wrote the tests with the same. I have pulled this into the new SDK version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #39
This allows for the easy ability to timeout if for some reason featurehub is unreachable.