[WIP] Upgrade SQLAlchemy #5492
Closed
[WIP] Upgrade SQLAlchemy #5492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmpayton
commented
Jul 12, 2023
tmpayton
commented
Jul 12, 2023
make passing in count required, apply options after counting, pass in session to marshmallow-pagination
|
We are postponing this upgrade because it will require some major re-writing to how we are connecting to the database. We discovered that we can no longer reset SQLALCHEMY_DATABASE_URI. Engines are now created when calling init_app rather than the first time they are accessed. The current recommended way of getting around this issue is to build an app factory. These changes would require us to re-create the app when we need to reset the connections. This is extremely high risk for us. Here's a helpful discussion of the issue: We will be watching and continuing to work on solutions in case this upgrade becomes more urgent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary (required)
(Include a summary of proposed changes and connect issue below)
Required reviewers
(Include who is required to review prior to merge. For example: One designer and two front end developer reviews are required prior to merge)
Impacted areas of the application
General components of the application that this PR will affect:
Screenshots
(Include a screenshot of the new/updated features in context (“in the wild”). If it is an interface change, include both before and after screenshots)
Related PRs
Related PRs against other branches:
How to test
(Include any information that may be helpful to the reviewer(s). This might include links to sample pages to test or any local environmental setup that is unusual such as environment variable (never credentials), API version to point to, etc)
System architecture updates (if applicable)
(If this pull request changes our current system diagram, include a description of those changes here and create a new ticket to update the system diagram)