Add verify lightning address and lnurl-pay support#251
Add verify lightning address and lnurl-pay support#251Sky-walkerX wants to merge 8 commits intofedimint:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 191fcaf The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@Sky-walkerX Have you tested if it works? |
|
+1 to @MrImmortal09's comment. Also, please add a test for each of the new RPCs. And if you're feeling ambitious, add a docs page for each as well. |
I have tested the methods, yes they work in UI. 
I'll add the version bump as well as tests, docs for the RPCs soon. |
|
Added the tests, the one failing is due to network mismatch. |
Sky-walkerX
force-pushed
the
addLightningVerifyAndPay
branch
from
252e4db to
21556fe
Compare
Seems like you implemented the functions in one of the examples, but they’re missing from the PR diff. Could you please add them as well? |
In all demo examples, right? |
Yes. |
Added them. |
|
Made the changes, please review when available. |
Sky-walkerX
force-pushed
the
addLightningVerifyAndPay
branch
2 times, most recently
from
39d9ef3 to
6eef9f4
Compare
MrImmortal09
left a comment
MrImmortal09
left a comment
There was a problem hiding this comment.
You will also need to bump the wasm in flake.nix.
In examples, show the meta data as well in the verifyy lightning address function, like maxSendable minSendable.
| @@ -0,0 +1,8 @@ | |||
| --- | |||
| '@fedimint/core': minor | |||
| await wallet.open() | ||
|
|
||
| const payment = await wallet.lightning.payLightningAddress( | ||
| // [!code focus] |
There was a problem hiding this comment.
add this & similar files to prettierignore
There was a problem hiding this comment.
@MrImmortal09, made the changes. please review.
|
@Sky-walkerX Please check the merge conflicts, as #271 is merged, do verify if we require a wasm bump again or not. |
Sky-walkerX
force-pushed
the
addLightningVerifyAndPay
branch
from
4d30156 to
191fcaf
Compare
|
@MrImmortal09, resolved the conflict. We required a wasm bump again. |
3 participants
Closes #221.
Corresponding fedimint PR -> fedimint/fedimint#8377