Skip to content

Commit

Permalink
fix: remove getLastRelease to support semantic-release v12
Browse files Browse the repository at this point in the history
semantic-release v12 requires getLastRelease to return a commit ID,
which the VS Code marketplace does not provide.

BREAKING CHANGE:
You need to change your package.json to use @semantic-release/git for
getLastRelease instead of semantic-release-vsce
  • Loading branch information
felixfbecker committed Feb 3, 2018
1 parent 924ab3b commit aa932f9
Show file tree
Hide file tree
Showing 5 changed files with 39 additions and 76 deletions.
13 changes: 8 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,20 +8,21 @@
[![Greenkeeper](https://badges.greenkeeper.io/raix/semantic-release-vsce.svg)](https://greenkeeper.io/)
[![semantic-release](https://img.shields.io/badge/%20%20%F0%9F%93%A6%F0%9F%9A%80-semantic--release-e10079.svg)](https://github.com/semantic-release/semantic-release)

Semantic release plugin for vs code extensions

NOTE: This package is still experimental - `semantic-release` multi plugins are not released
Semantic release plugin for Visual Stuio Code extensions

#### Add config to package.json

Use `semantic-release-vsce` as part of `verifyConditions` and `publish`.
For `getLastRelease` you should use `@semantic-release/git` (instead of the default npm implementation).

```json
{
"scripts": {
"semantic-release": "semantic-release"
},
"release": {
"verifyConditions": ["semantic-release-vsce", "@semantic-release/github"],
"getLastRelease": "semantic-release-vsce",
"getLastRelease": "@semantic-release/git",
"publish": [
{
"path": "semantic-release-vsce",
Expand All @@ -34,7 +35,9 @@ NOTE: This package is still experimental - `semantic-release` multi plugins are
]
},
"devDependencies": {
"semantic-release": "^11.0.0"
"@semantic-release/git": "^2.0.0",
"semantic-release": "^12.0.0",
"semantic-release-vsce": "^2.0.0",
}
}
```
Expand Down
10 changes: 0 additions & 10 deletions index.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
const verifyVsce = require('./lib/verify');
const vscePublish = require('./lib/publish');
const getLastReleaseGallery = require('./lib/get-last-release');

let verified;

Expand All @@ -9,14 +8,6 @@ async function verifyConditions (pluginConfig, {logger}) {
verified = true;
}

async function getLastRelease (pluginConfig, {logger}) {
if (!verified) {
await verifyVsce(logger);
verified = true;
}
return getLastReleaseGallery(logger);
}

async function publish (pluginConfig, {nextRelease: {version}, logger}) {
if (!verified) {
await verifyVsce(logger);
Expand All @@ -27,6 +18,5 @@ async function publish (pluginConfig, {nextRelease: {version}, logger}) {

module.exports = {
verifyConditions,
getLastRelease,
publish
};
60 changes: 0 additions & 60 deletions lib/get-last-release.js

This file was deleted.

30 changes: 30 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"semantic-release": "^12.2.2"
},
"peerDependencies": {
"semantic-release": "^11.0.0"
"semantic-release": "^12.0.0"
},
"release": {
"verifyConditions": "@semantic-release/github"
Expand Down

0 comments on commit aa932f9

Please sign in to comment.