Skip to content

Conversation

@Soptq
Copy link

@Soptq Soptq commented Dec 10, 2017

1.make notification visible on lockscreen

2.add Chninese Translation

1.make notification visible on lockscreen

2.add Chninese Translation
@fennifith
Copy link
Owner

This does fix the issue, but it kind of breaks the idea of making the notification always dismissable, and instead sends an ongoing notification by default, and only makes it dismissable when the always dismissable switch is enabled and nothing is playing.

Recommended fix: replace the "always dismissable" switch with a drop-down allowing users to select either "always", "only when paused", or "never". I'll work on this tomorrow if I have time.

.setVisibility(NotificationCompat.VISIBILITY_PUBLIC)
@Soptq
Copy link
Author

Soptq commented Dec 10, 2017

Ok,i will have a try later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants