Add support for transfer acceleration without the need of fully custom managed bucket #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will try to review and test this in the upcoming weeks if you want to help us shorten the feedback cycle can you please rebase this off of master and test it out with serverless 3 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
I can't deploy some of my projects with serverless' --aws-s3-accelerate option enabled as the S3 bucket is by default not transfer acceleration enabled. I noticed there is a manageResources flag for a fully custom S3 bucket where I could enable the transfer acceleration but would have preferred to keep everything default and out of the box ready.
Proposed changes
Unless this bloats the library too much I figured the transfer acceleration could be added as an option.