adds logic to upload compressed files with right mime type and right content-encoding #109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
##81
Proposed changes
If not specified within the
objectHeaders
option, uploaded objects are given a content-type header automatically based on their file extension using mime 's lookup function. Unfortunately, this causes problems if you attempt to upload a file with a file extension + a compression extension. iemain.123.js.gz
.Now, there aren't any standards (that I know of ) to reference here, but the common practice that I've seen is that gzip compressed files follow the pattern
*.{file-extension}.gz
and brotli compressed files follow this pattern:
*.{file-extension}.br
I haven't come across anything for other compression encoding types, but I would be happy to add support in this PR
If we assume that users who precompress their file will follow the above described practice, then this merging this PR will do the following:
*.*.br
will be given aContent-Encoding
header value ofbr
, in accordance with brotli standard*.*.gz
will be given aContent-Encoding
header value ofgzip
in accordance with gzip standard