chore: fix deprecation warning#62
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesConfig Update
Estimated code review effort: 1 (Trivial) | ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates the @chonkiejs/token TypeScript configuration to eliminate the TS5107 deprecation warning during npm run build by aligning module resolution with the rest of the repo’s current setup.
Changes:
- Switch
packages/token/tsconfig.jsonfrom"moduleResolution": "node"(deprecated via thenode10legacy mode) to"moduleResolution": "bundler".
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/token/tsconfig.json (1)
3-6: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueConsider aligning
modulewithmoduleResolution: "bundler".TS5095 only requires
moduleto be"es2015"or later when usingmoduleResolution: "bundler", so"ES2020"here won't break the build. However, TypeScript's own guidance for "bundler" mode recommends pairing it with"module": "esnext"(or"preserve"), which is what the repo roottsconfig.jsonand@chonkiejs/corealready do. Keepingmodule: "ES2020"here is a minor inconsistency with the rest of the monorepo and diverges from the documented "bundler" resolution intent, though it should compile fine as-is.♻️ Optional alignment
"compilerOptions": { "target": "ES2021", - "module": "ES2020", + "module": "ESNext", "lib": ["ES2021"], "moduleResolution": "bundler",🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/token/tsconfig.json` around lines 3 - 6, The TypeScript config in this package is slightly inconsistent with the monorepo’s bundler setup. Update the package tsconfig to align the module setting with moduleResolution: "bundler" by matching the repo’s existing convention in tsconfig.json and `@chonkiejs/core`, using the same module style as the rest of the workspace rather than keeping "ES2020".
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/token/tsconfig.json`:
- Around line 3-6: The TypeScript config in this package is slightly
inconsistent with the monorepo’s bundler setup. Update the package tsconfig to
align the module setting with moduleResolution: "bundler" by matching the repo’s
existing convention in tsconfig.json and `@chonkiejs/core`, using the same module
style as the rest of the workspace rather than keeping "ES2020".
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: e5ba2a3e-f8f8-40d5-8e52-ab92de55148d
📒 Files selected for processing (1)
packages/token/tsconfig.json
without this
npm run buildgenerates the following errorthis pr switches to
"moduleResolution": "bundler"following our implementation in @chonkiejs/coreSummary by CodeRabbit