Skip to content

build: add oxlint and oxfmt tooling#65

Open
azizbecha wants to merge 1 commit into
feyninc:mainfrom
azizbecha:feat/oxlint-oxfmt
Open

build: add oxlint and oxfmt tooling#65
azizbecha wants to merge 1 commit into
feyninc:mainfrom
azizbecha:feat/oxlint-oxfmt

Conversation

@azizbecha

@azizbecha azizbecha commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds oxlint (linter) and oxfmt (formatter) to the monorepo, plus a committed .vscode folder so contributors get a consistent editor setup out of the box.

Changes

  • Install oxlint and oxfmt as root dev dependencies
  • .oxlintrc.json β€” correctness rules as warnings; ignores dist, legacy, and docs build output
  • .oxfmtrc.json β€” formatter config with the same ignores
  • .vscode/extensions.json β€” recommends the official oxc.oxc-vscode extension
  • .vscode/settings.json β€” enables fix-on-save (source.fixAll.oxc), sets oxc as default formatter with format-on-save
  • New root scripts: lint, lint:fix, format, format:check
  • Removed .vscode from .gitignore (it was ignored, so the folder could never be committed)

Notes

  • Type-aware linting is not enabled (requires the extra oxlint-tsgolint dependency) β€” can be a follow-up
  • pnpm lint currently reports warnings on existing code (unused vars in handshakes/tests); nothing blocking
  • pnpm format:check reports ~109 unformatted files β€” the repo-wide reformat is intentionally excluded to keep this diff reviewable, and can land as a separate PR

Test plan

  • pnpm lint runs and respects the config
  • pnpm format:check runs and respects the config

Summary by CodeRabbit

  • New Features

    • Added project formatting and linting commands for easier local code checks and cleanup.
    • Included editor recommendations and save-time formatting settings for a smoother development experience.
  • Chores

    • Added configuration for formatting and linting tools, with ignore rules for generated and build output.
    • Updated repository ignore rules to allow editor workspace settings to be tracked when needed.

Add oxlint (linter) and oxfmt (formatter) as root dev dependencies with
config files and npm scripts. Commit .vscode folder with the oxc
extension recommendation and fix/format-on-save settings so contributors
get a consistent editor setup out of the box.
@vercel

vercel Bot commented Jul 7, 2026

Copy link
Copy Markdown

@azizbecha is attempting to deploy a commit to the Chonkie Inc Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. πŸŽ‰

ℹ️ Recent review info
βš™οΈ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c172e52b-62a4-4d31-ac90-bd1c922c95d5

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 6a98fd9 and a177337.

β›” Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
πŸ“’ Files selected for processing (6)
  • .gitignore
  • .oxfmtrc.json
  • .oxlintrc.json
  • .vscode/extensions.json
  • .vscode/settings.json
  • package.json
πŸ’€ Files with no reviewable changes (1)
  • .gitignore

πŸ“ Walkthrough

Walkthrough

This PR introduces oxc-based tooling (oxlint, oxfmt) to the repository, adding configuration files, VS Code editor integration, and root package.json scripts and devDependencies, while removing the .vscode entry from .gitignore.

Changes

Oxc Tooling Adoption

Layer / File(s) Summary
Lint/format configuration
.oxlintrc.json, .oxfmtrc.json
New configs define oxlint correctness rules (warn) and oxfmt ignore patterns for build/legacy/docs directories.
VS Code integration
.gitignore, .vscode/extensions.json, .vscode/settings.json
.vscode removed from .gitignore; extensions recommend oxc.oxc-vscode; settings enable format-on-save and fixAll via oxc.
Root scripts and dependencies
package.json
Adds lint, lint:fix, format, format:check scripts and oxfmt/oxlint devDependencies.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Poem

Hop, hop, through configs I go,
Oxc tools now start to glow,
Format on save, lint on cue,
.vscode unhidden, fresh and new,
A tidy warren, code so bright! πŸ‡βœ¨

πŸš₯ Pre-merge checks | βœ… 5
βœ… Passed checks (5 passed)
Check name Status Explanation
Description Check βœ… Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check βœ… Passed The title clearly summarizes the main change: adding oxlint and oxfmt tooling.
Docstring Coverage βœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check βœ… Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check βœ… Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant