refactor: migrate variables sample to TS #158
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasaHirano
commented
Dec 4, 2023
| { | ||
| "compilerOptions": { | ||
| "target": "ES6", | ||
| "lib": ["ES2017"], |
There was a problem hiding this comment.
It requires ES2017 or newer unlike other samples using ES6. That's because in this code, functions like Object.entries are used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I am creating a plugin based on the
variables-import-exportsample. I found the code is relatively more complicated than other samples. Migrating it to TS as well as other samples will be beneficial from the perspective of readability and customizability.