Repository navigation
feat: add upload count to sample - #81
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
馃煛 Changes recommended
The JSON decoder still accepts empty arrays as zero-valued samples, leaving wire validation inconsistent.
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
Adds UploadCount to metrics samples so consumers can derive object counts.
Changes:
- Extends CBOR and DAG-JSON tuple codecs.
- Updates round-trip tests and fixtures.
- Documents the new field and wire format.
| File | Description |
|---|---|
commands/鈥媘etrics/鈥媡ypes.go |
Adds and documents UploadCount. |
commands/鈥媘etrics/鈥媕son_gen.tuples.go |
Encodes and decodes the fourth DAG-JSON field. |
commands/鈥媘etrics/鈥媍odec_test.go |
Updates codec round-trip coverage. |
commands/鈥媘etrics/鈥媍bor_gen.tuples.go |
Encodes and decodes the fourth CBOR field. |
Files not reviewed (2)
- commands/metrics/cbor_gen.tuples.go: Generated file
- commands/metrics/json_gen.tuples.go: Generated file
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
Copilot review overview
馃數 Needs a closer look
The change spans generated serialization code and dependency updates, warranting final human review.
Review effort: Lite
Findings: None
Resolved since last review (2)
Files not reviewed (4)
- blobindex/datamodel/json_gen.tuples.go: Generated file
- commands/content/json_gen.tuples.go: Generated file
- commands/metrics/cbor_gen.tuples.go: Generated file
- commands/metrics/json_gen.tuples.go: Generated file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upload count is mapped to object count - ingot uses it to count objects in a space fil-forge/ingot#176