Skip to content

feat: add timestamp to agent index table - #129

Merged
alanshaw merged 3 commits into
mainfrom
ash/feat/agent-index-inserted-at
Oct 5, 2026
Merged

alanshaw merged 3 commits into
mainfrom
ash/feat/agent-index-inserted-at

Conversation

@alanshaw

@alanshaw alanshaw commented Oct 5, 2026

Copy link
Copy Markdown
Member

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The blocking index creation could stall production writes while migrating a large agent-index table.

Review effort: Balanced
Findings: 1 High severity · 1 Low severity

Open (2)
What changed in this PR

Adds timestamps to PostgreSQL agent-index entries to support age-based purging.

Changes:

  • Adds inserted_at with backfill and an index.
  • Tests migration behavior for existing and new rows.
File Description
internal/​migrations/​sql/​00006_agent_index_inserted_at.sql Adds the timestamp column and purge index.
internal/​migrations/​agent_index_test.go Verifies backfill, defaults, and index creation.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread internal/migrations/sql/00006_agent_index_inserted_at.sql
Comment thread internal/migrations/agent_index_test.go Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The migration and its integration test correctly cover existing and newly inserted rows.

Review effort: Balanced
Findings: None

Resolved since last review (2)

@alanshaw
alanshaw merged commit 9b40689 into main Oct 5, 2026
9 checks passed
@alanshaw
alanshaw deleted the ash/feat/agent-index-inserted-at branch October 5, 2026 16:28
fil-forge-bot Bot added a commit to fil-forge/infra-central that referenced this pull request Oct 5, 2026
Published from fil-forge/sprue#129

- Digest: `sha256:79eb33d967f163fb7370ce4cacb757428f551466625e191ed774efa949327cb1`
- Commit: fil-forge/sprue@9b40689
- Publish run: https://github.com/fil-forge/sprue/actions/runs/37341126537

Merging applies [`terraform/envs/dev/apps`](https://github.com/fil-forge/infra-central/tree/main/terraform/envs/dev/apps) with no further confirmation.

Co-authored-by: fil-forge-bot[bot] <318653112+fil-forge-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants