Repository navigation
fix: request context - #70
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
馃煛 Changes recommended
The exported codec contract breaks existing downstream implementations and needs a compatibility-preserving approach.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
This pull request propagates caller context through outbound HTTP requests, including cancellation and context values.
Changes:
- Updates outbound codec encoding to accept context.
- Attaches context to HTTP requests.
- Adds propagation and cancellation tests.
| File | Summary |
|---|---|
transport/鈥媡ransport.go |
Updates the outbound codec contract. |
transport/鈥媍odec.go |
Attaches context to HTTP requests. |
transport/鈥媍odec_test.go |
Tests context propagation. |
client/鈥媓ttp_test.go |
Tests context values and cancellation. |
client/鈥媍lient.go |
Forwards execution context to the codec. |
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
alanshaw
added a commit
to fil-forge/libforge
that referenced
this pull request
Sep 24, 2026
alanshaw
added a commit
to fil-forge/ingot
that referenced
this pull request
Sep 24, 2026
Upgrades ucantone to bring in the context fix, which allows distributed tracing to work. refs fil-forge/ucantone#70
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retain the context across HTTP requests.