Repository navigation
chore: upgrade dag-json-gen - #72
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
馃煛 Changes recommended
Add regression tests covering malformed empty tuple decoding.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Upgrades dag-json-gen to v0.0.10 and regenerates tuple decoders to reject malformed empty or underspecified DAG-JSON tuples.
Changes:
- Updates the generator dependency and checksums.
- Adds required-field validation to envelope and policy decoders.
| File | Summary |
|---|---|
ucan/鈥媏nvelope/鈥媎atamodel/鈥媎ag_json_gen.go |
Rejects empty envelope tuples; add a regression test. |
ucan/鈥媎elegation/鈥媝olicy/鈥媎atamodel/鈥媎ag_json_gen.go |
Rejects underspecified policy tuples; add regression coverage. |
go.sum |
Records v0.0.10 dependency checksums. |
go.mod |
Upgrades dag-json-gen to v0.0.10. |
Files not reviewed (2)
- ucan/delegation/policy/datamodel/dag_json_gen.go: Generated file
- ucan/envelope/datamodel/dag_json_gen.go: Generated file
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| if err := jr.ReadArrayClose(); err != nil { | ||
| return fmt.Errorf("reading array close for field EnvelopeModel: %w", err) | ||
| } | ||
| return fmt.Errorf("json input has too few fields 0 < 2") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade
dag-json-gento bring in tuple decoding fix alanshaw/dag-json-gen#3